[ GPU ] fix return by reference to return by value #2753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- In the previous code, `registerClKernel` function returned reference of SharedPtrClKernel, which has two problems: - returning by reference cannot return nullptr, leading an error in line 169 of `cl_context.cpp` - returning by reference of `shared_ptr` may not increase the reference counter, leading to early free problem. Signed-off-by: Eunju Yang <[email protected]>
EunjuYang
requested review from
myungjoo,
jijoongmoon,
again4you,
jaeyun-jung,
leemgs,
wooksong,
helloahn,
kparichay,
gichan-jang,
anyj0527,
zhoonit,
lhs8928,
songgot,
jihochu,
DonghakPark and
SeoHyungjun
as code owners
|
📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #2753. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/. |
EunjuYang
requested review from
baek2sm,
skykongkong8,
djeong20 and
a team
as code owners
taos-ci
approved these changes
Oct 10, 2024
There was a problem hiding this comment.
@EunjuYang, 💯 All CI checkers are successfully verified. Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
registerClKernelfunction returned reference ofSharedPtrClKernel, causing the possible two problems:cl_context.cppshared_ptrmay not increase the reference counter, leading to early free problem.