Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[trivial] remove unnecessary code #2678

Merged
merged 1 commit into from
Jul 24, 2024
Merged

[trivial] remove unnecessary code #2678

merged 1 commit into from
Jul 24, 2024

Conversation

djeong20
Copy link
Contributor

This PR removes the print statement that was previously added for debugging purposes.

Self-evaluation:

  1. Build test: [X]Passed [ ]Failed [ ]Skipped
  2. Run test: [X]Passed [ ]Failed [ ]Skipped

@djeong20
[trivial] remove unnecessary code
586a6a2 
This PR removes the print statement that was previously added for debugging purposes.

**Self-evaluation:**
1. Build test: [X]Passed [ ]Failed [ ]Skipped
2. Run test:   [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: Donghyeon Jeong <[email protected]>
@taos-ci
Copy link

taos-ci commented Jul 17, 2024

📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #2678. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.

taos-ci
taos-ci approved these changes Jul 17, 2024
View reviewed changes
Copy link

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@djeong20, 💯 All CI checkers are successfully verified. Thanks.

SeoHyungjun
SeoHyungjun approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@SeoHyungjun SeoHyungjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about making it only for use in debug mode?

DonghakPark
DonghakPark approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@DonghakPark DonghakPark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Catch !!

@djeong20
Copy link
Contributor Author

How about making it only for use in debug mode?

When checking test results, this code makes readability low and seems irrelevant for model debugging, so I thought it would be better to remove it.

[ RUN      ] multiInoutModels/nntrainerModelTest.model_test_save_load_compare/one_to_one
num iter: 2
iteration: 0
iteration: 1
[       OK ] multiInoutModels/nntrainerModelTest.model_test_save_load_compare/one_to_one (1 ms)
[ RUN      ] multiInoutModels/nntrainerModelTest.model_test_save_load_compare/one_to_one__reversed
num iter: 2
iteration: 0
iteration: 1
[       OK ] multiInoutModels/nntrainerModelTest.model_test_save_load_compare/one_to_one__reversed (0 ms)
[ RUN      ] multiInoutModels/nntrainerModelTest.model_test_save_load_compare/one_to_many
num iter: 2
iteration: 0
iteration: 1
[       OK ] multiInoutModels/nntrainerModelTest.model_test_save_load_compare/one_to_many (2 ms)
[ RUN      ] multiInoutModels/nntrainerModelTest.model_test_save_load_compare/split_and_join_dangle
num iter: 3
iteration: 0
iteration: 1
iteration: 2

baek2sm
baek2sm approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@baek2sm baek2sm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

lhs8928
lhs8928 approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@lhs8928 lhs8928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@myungjoo myungjoo merged commit 8909800 into nnstreamer:main Jul 24, 2024
43 checks passed
@djeong20 djeong20 deleted the update/models_test_utils branch July 26, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skykongkong8 skykongkong8 skykongkong8 approved these changes

@DonghakPark DonghakPark DonghakPark approved these changes

@taos-ci taos-ci taos-ci approved these changes

@SeoHyungjun SeoHyungjun SeoHyungjun approved these changes

@baek2sm baek2sm baek2sm approved these changes

@lhs8928 lhs8928 lhs8928 approved these changes

@EunjuYang EunjuYang EunjuYang approved these changes

@myungjoo myungjoo Awaiting requested review from myungjoo myungjoo is a code owner

@jijoongmoon jijoongmoon Awaiting requested review from jijoongmoon jijoongmoon is a code owner

@again4you again4you Awaiting requested review from again4you again4you is a code owner

@jaeyun-jung jaeyun-jung Awaiting requested review from jaeyun-jung jaeyun-jung is a code owner

@leemgs leemgs Awaiting requested review from leemgs leemgs is a code owner

@wooksong wooksong Awaiting requested review from wooksong wooksong is a code owner

@helloahn helloahn Awaiting requested review from helloahn

@kparichay kparichay Awaiting requested review from kparichay

@gichan-jang gichan-jang Awaiting requested review from gichan-jang gichan-jang is a code owner

@anyj0527 anyj0527 Awaiting requested review from anyj0527 anyj0527 is a code owner

@zhoonit zhoonit Awaiting requested review from zhoonit

@songgot songgot Awaiting requested review from songgot songgot is a code owner

@jihochu jihochu Awaiting requested review from jihochu jihochu is a code owner

Assignees
No one assigned
Labels
PR/READY2MERGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@djeong20 @taos-ci @EunjuYang @lhs8928 @baek2sm @SeoHyungjun @DonghakPark @skykongkong8 @myungjoo