[GPU/OpenCL] Moving Addition kernel to Tensor Directory @open sesame 07/04 09:01 #2666
Conversation
Moved addition_cl kernel to Tensor directory. Refactored addition_cl for generalization. Signed-off-by: Yash Singh <[email protected]>
yashSingh0723
requested review from
myungjoo,
jijoongmoon,
again4you,
jaeyun-jung,
leemgs,
wooksong,
helloahn,
kparichay,
gichan-jang,
anyj0527,
zhoonit,
lhs8928,
songgot,
jihochu,
DonghakPark,
SeoHyungjun,
baek2sm,
skykongkong8,
djeong20,
EunjuYang and
a team
as code owners
|
📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #2666. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/. |
|
|
cibot: 
| * @param[in] result Tensor | ||
| * @param[in] RunLayerContext reference | ||
| */ | ||
| void add_i_cl(Tensor const &input, Tensor &result, RunLayerContext &context); |
There was a problem hiding this comment.
this is not a big deal but how about renaming it as add_cl() for clarity since Tensor uses _i as in-place operations. (which in this case takes an output tensor)
There was a problem hiding this comment.
+) What about naming it as addCl to make it consistent with other kernel operations?
There was a problem hiding this comment.
Actually I was following the cpu naming convention, for cpu implementation it is named as add_i. And for the GPU kernel as well I am doing the in-place operation. So inorder to add input[0] and input[1], I am storing the result as input[0] += input[1], not creating any other output tensor additionally and treating input[0] as output tensor. Followed the CPU implementation only.
But still if I need to change the name to addCL, Please tell and I'll do it accordingly.
djeong20
changed the title
There was a problem hiding this comment.
@yashSingh0723, 💯 All CI checkers are successfully verified. Thanks.
Moved
addition_clkernel to Tensor directory and refactored it for generalization.Naming convention changed for
fp16inaddition_layerunittests.