Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] update README.md @open sesame 06/18 13:33 #2644

Merged
merged 3 commits into from
Jun 25, 2024

Conversation

EunjuYang
Copy link
Contributor

This PR contains commits to

  • add recent NNTrainer paper and its citation to README.md
  • fix trivial typo in README.md

@taos-ci
Copy link

taos-ci commented Jun 18, 2024

📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #2644. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.

Copy link
Member

@skykongkong8 skykongkong8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now we got it right ;) LGTM

@skykongkong8 skykongkong8 changed the title [DOCS] update README.md [DOCS] update README.md @open sesame 06/18 13:33 Jun 18, 2024
Copy link

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EunjuYang, 💯 All CI checkers are successfully verified. Thanks.

Copy link
Member

@DonghakPark DonghakPark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

Copy link
Contributor

@baek2sm baek2sm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks good to add citation info. LGTM!

README.md Outdated Show resolved Hide resolved
@myungjoo
Copy link
Member

Merge when @djeong20 's comment is applied.

@taos-ci
Copy link

taos-ci commented Jun 20, 2024

To contributor, We have used 'Signed-off-by:' notation by default to handle the license issues, that result from contributors. Note that 'Is there a Signed-off-by line?' is important because lawyers tell us we must have to it to cleanly maintain the open-source license issues even though it has nothing to do with the code itself.

Copy link

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EunjuYang, 💯 All CI checkers are successfully verified. Thanks.

EunjuYang and others added 3 commits June 20, 2024 10:51
- This commit updates `README.md` to include recent publication and its
citation.

Signed-off-by: Eunju Yang <[email protected]>
- This commit fixes typo in README.md

Signed-off-by: Eunju Yang <[email protected]>
- Update out-dated link with the recent one.

Co-authored-by: Donghyeon Jeong <[email protected]>
Signed-off-by: Donghyeon Jeong <[email protected]>
Copy link

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EunjuYang, 💯 All CI checkers are successfully verified. Thanks.

Copy link
Member

@SeoHyungjun SeoHyungjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@myungjoo myungjoo merged commit 6ff2d38 into nnstreamer:main Jun 25, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants