Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ bug ] Use fp16 when applying sqrt_i #2454

Merged
merged 1 commit into from
Feb 6, 2024
Merged

[ bug ] Use fp16 when applying sqrt_i #2454

merged 1 commit into from
Feb 6, 2024

Conversation

skykongkong8
Copy link
Member

  • std::sqrt does not support fp16, so need to be casted
  • Have to re-cast to fp16 when using apply function with _Float16 ( not __fp16 )

Self evaluation:

  1. Build test: [X]Passed [ ]Failed [ ]Skipped
  2. Run test: [X]Passed [ ]Failed [ ]Skipped

@skykongkong8 skykongkong8 added the bug Something isn't working label Feb 2, 2024
@taos-ci
Copy link

taos-ci commented Feb 2, 2024

📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #2454. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.

@taos-ci
Copy link

taos-ci commented Feb 2, 2024

:octocat: cibot: @skykongkong8, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nntrainer/ci/repo-workers/pr-checker/2454-202402021527310.19253206253052-ec558d59e0772648d639b0d6c4c7a43b9e147bcc/.

@skykongkong8
[ bug ] Use fp16 when apply sqrt_i
d6800ee 
- std::sqrt does not support fp16, so need to be casted
- Have to re-cast to fp16 when using _Float16 ( not __fp16 )

**Self evaluation:**
1. Build test:	 [X]Passed [ ]Failed [ ]Skipped
2. Run test:	 [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: skykongkong8 <[email protected]>
@skykongkong8 skykongkong8 changed the title [ Wait for #2453 ] [ bug ] Use fp16 when applying sqrt_i [ bug ] Use fp16 when applying sqrt_i Feb 5, 2024
jijoongmoon
jijoongmoon approved these changes Feb 5, 2024
View reviewed changes
Copy link
Collaborator

@jijoongmoon jijoongmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jihochu
jihochu approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@jihochu jihochu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

djeong20
djeong20 approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@djeong20 djeong20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

taos-ci
taos-ci approved these changes Feb 5, 2024
View reviewed changes
Copy link

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skykongkong8, 💯 All CI checkers are successfully verified. Thanks.

lhs8928
lhs8928 approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@lhs8928 lhs8928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jijoongmoon jijoongmoon merged commit ca0bf03 into nnstreamer:main Feb 6, 2024
36 checks passed
@skykongkong8 skykongkong8 deleted the sqrt_debug branch March 4, 2024 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djeong20 djeong20 djeong20 approved these changes

@taos-ci taos-ci taos-ci approved these changes

@lhs8928 lhs8928 lhs8928 approved these changes

@jijoongmoon jijoongmoon jijoongmoon approved these changes

@jihochu jihochu jihochu approved these changes

@myungjoo myungjoo Awaiting requested review from myungjoo myungjoo is a code owner

@again4you again4you Awaiting requested review from again4you again4you is a code owner

@jaeyun-jung jaeyun-jung Awaiting requested review from jaeyun-jung jaeyun-jung is a code owner

@leemgs leemgs Awaiting requested review from leemgs leemgs is a code owner

@wooksong wooksong Awaiting requested review from wooksong wooksong is a code owner

@helloahn helloahn Awaiting requested review from helloahn

@kparichay kparichay Awaiting requested review from kparichay

@gichan-jang gichan-jang Awaiting requested review from gichan-jang gichan-jang is a code owner

@anyj0527 anyj0527 Awaiting requested review from anyj0527 anyj0527 is a code owner

@zhoonit zhoonit Awaiting requested review from zhoonit

@songgot songgot Awaiting requested review from songgot songgot is a code owner

@DonghakPark DonghakPark Awaiting requested review from DonghakPark DonghakPark is a code owner

@SeoHyungjun SeoHyungjun Awaiting requested review from SeoHyungjun SeoHyungjun is a code owner

@baek2sm baek2sm Awaiting requested review from baek2sm baek2sm is a code owner

@EunjuYang EunjuYang Awaiting requested review from EunjuYang EunjuYang is a code owner

Assignees
No one assigned
Labels
bug Something isn't working PR/READY2MERGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@skykongkong8 @taos-ci @jihochu @jijoongmoon @lhs8928 @djeong20