Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[coverity] Fix coverity issues #2440

Merged
merged 1 commit into from
Feb 1, 2024
Merged

[coverity] Fix coverity issues #2440

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion nntrainer/layers/layer_context.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ class InitLayerContext {
bool trainable = false,
TensorLifespan lifespan = TensorLifespan::ITERATION_LIFESPAN,
bool private_ = true) {
auto prefix_ = private_ ? this->name : this->prefix;
const auto &prefix_ = private_ ? this->name : this->prefix;
tensors_spec.emplace_back(dim, init, trainable, prefix_ + ":" + name,
lifespan);
return tensors_spec.size() - 1;
Expand Down
10 changes: 6 additions & 4 deletions nntrainer/layers/layer_node.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,9 +305,11 @@ const std::vector<std::string> LayerNode::getInputLayers() const {
std::get<std::vector<props::InputConnection>>(*layer_node_props);
std::vector<std::string> names;
names.reserve(input_connections.size());
std::transform(input_connections.begin(), input_connections.end(),
std::back_inserter(names),
[](const Connection &con) { return con.getName(); });
std::transform(
input_connections.begin(), input_connections.end(),
std::back_inserter(names), [](const Connection &con) -> const auto & {
return con.getName();
});
return names;
}

Expand Down Expand Up @@ -571,7 +573,7 @@ InitLayerContext LayerNode::finalize(const std::vector<TensorDim> &input_dims,
layer = std::move(dlayer);
}

auto scope = getSharedFrom().empty() ? getName() : getSharedFrom();
const auto &scope = getSharedFrom().empty() ? getName() : getSharedFrom();
float max_norm = 0.0;
if (!std::get<props::ClipGradByGlobalNorm>(*layer_node_props).empty())
max_norm = std::get<props::ClipGradByGlobalNorm>(*layer_node_props).get();
Expand Down
3 changes: 2 additions & 1 deletion nntrainer/models/neuralnet.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1381,7 +1381,8 @@ void NeuralNetwork::print(std::ostream &out, unsigned int flags,
std::vector<unsigned int> column_size = {20, 20, 20, 20};
auto print_graph_layer_info =
[column_size](std::ostream &out, std::vector<std::string> layer_info) {
auto trim_string = [](std::string str, unsigned int column_width) {
const auto &trim_string = [](std::string str,
unsigned int column_width) {
return str.size() < column_width ? str
: str.substr(0, column_width - 1);
};
Expand Down
Loading