[Test] TensorV2 multiplication unit test #2433
Conversation
djeong20
requested review from
myungjoo,
jijoongmoon,
again4you,
jaeyun-jung,
leemgs,
wooksong,
helloahn,
kparichay,
gichan-jang,
anyj0527,
zhoonit,
lhs8928,
songgot,
jihochu,
DonghakPark,
SeoHyungjun,
baek2sm,
skykongkong8,
EunjuYang and
a team
as code owners
|
📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #2433. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/. |
| _FP16 answer_data[] = {static_cast<_FP16>(0), static_cast<_FP16>(1), | ||
| static_cast<_FP16>(4), static_cast<_FP16>(9), | ||
| static_cast<_FP16>(16), static_cast<_FP16>(25), | ||
| static_cast<_FP16>(36), static_cast<_FP16>(49), | ||
| static_cast<_FP16>(64), static_cast<_FP16>(81), |
There was a problem hiding this comment.
all these static_cast to _FP16 is making readability very low.
if anyone has a good idea, please give me a suggestion!
There was a problem hiding this comment.
why don't you make Macro or Function that can convert to FP16?
There was a problem hiding this comment.
for example
template <typename T> // T models Any
struct static_cast_func
{
template <typename T1> // T1 models type statically convertible to T
T operator()(const T1& x) const { return static_cast<T>(x); }
};std::transform(char_buff, char_buff + len, float_buff, static_cast_func<float>());like this
There was a problem hiding this comment.
thanks :) this really helped a lot
| float *indata = input.getData<float>(); | ||
| ASSERT_NE(nullptr, indata); | ||
|
|
||
| for (int i = 0; i < batch * height * width * channel; ++i) { |
There was a problem hiding this comment.
| for (int i = 0; i < batch * height * width * channel; ++i) { | |
| for (int i = 0; i < batch * channel * height * width; ++i) { |
?
This PR includes unit tests for verifying multiplication operations in the TensorV2 class. Note that all unit tests are the same as tests in unittest_nntrainer_tensor.cpp file. **Self-evaluation:** 1. Build test: [X]Passed [ ]Failed [ ]Skipped 2. Run test: [X]Passed [ ]Failed [ ]Skipped Signed-off-by: Donghyeon Jeong <[email protected]>
…orm() This commit replaces a manual static_cast operation with a helper struct that can be used with std::transform(). This change improves readability and maintainability by encapsulating the casting logic in a separate struct. suggessted by @DonghakPark Co-authored-by: Donghak Park <[email protected]> Signed-off-by: Donghyeon Jeong <[email protected]>
djeong20
force-pushed
the
test/tensor_v2/multiply
branch
from
cf26b09 to
d05bdc1
Compare
This PR includes unit tests for verifying multiplication operations in the TensorV2 class.
Note that all unit tests are the same as tests in unittest_nntrainer_tensor.cpp file.
Self-evaluation: