[TensorV2] Refactoring TensorBase pointer to shared_ptr #2428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR proposes refactoring the TensorV2 class to use a shared_ptr instead of a raw pointer for managing its TensorBase object. By adopting this change, we can improve the safety and reliability of our code and reduce the likelihood of memory leaks and other issues related to manual memory management. **Changes proposed in this PR:** - Replace the TensorBase pointer in the Tensor class with a shared_ptr. - Update any relevant code to use the shared_ptr instead of the raw pointer. **Self-evaluation:** 1. Build test: [X]Passed [ ]Failed [ ]Skipped 2. Run test: [X]Passed [ ]Failed [ ]Skipped Signed-off-by: Donghyeon Jeong <[email protected]>
djeong20
requested review from
myungjoo,
jijoongmoon,
again4you,
jaeyun-jung,
leemgs,
wooksong,
helloahn,
kparichay,
gichan-jang,
anyj0527,
zhoonit and
a team
as code owners
|
📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #2428. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/. |
jijoongmoon
reviewed
Jan 28, 2024
| @@ -79,14 +87,16 @@ TensorV2::TensorV2(const TensorDim &d, const void *buf) { | |||
| TensorV2::TensorV2( | |||
| std::vector<std::vector<std::vector<std::vector<float>>>> const &d, | |||
| ml::train::TensorDim::TensorType t_type) { | |||
| itensor = new FloatTensor(d, t_type.format); | |||
| itensor = std::shared_ptr<FloatTensor>(new FloatTensor(d, t_type.format), | |||
| std::default_delete<FloatTensor>()); | |||
| } | |||
|
|
|||
| #ifdef ENABLE_FP16 | |||
There was a problem hiding this comment.
It will be removed according to our offline discussion.
djeong20
added a commit
to djeong20/nntrainer
that referenced
this pull request
Feb 2, 2024
This PR resolves a bug that occurred after nnstreamer#2428 in the TensorV2 class when getting a shared data tensor, which shares memory. ** Self-evaluation** 1. Build test: [X]Passed [ ]Failed [ ]Skipped 2. Run test: [X]Passed [ ]Failed [ ]Skipped Signed-off-by: Donghyeon Jeong <[email protected]>
jijoongmoon
pushed a commit
that referenced
this pull request
Feb 5, 2024
This PR resolves a bug that occurred after #2428 in the TensorV2 class when getting a shared data tensor, which shares memory. ** Self-evaluation** 1. Build test: [X]Passed [ ]Failed [ ]Skipped 2. Run test: [X]Passed [ ]Failed [ ]Skipped Signed-off-by: Donghyeon Jeong <[email protected]>
EunjuYang
pushed a commit
to EunjuYang/nntrainer
that referenced
this pull request
Aug 28, 2024
This PR resolves a bug that occurred after nnstreamer#2428 in the TensorV2 class when getting a shared data tensor, which shares memory. ** Self-evaluation** 1. Build test: [X]Passed [ ]Failed [ ]Skipped 2. Run test: [X]Passed [ ]Failed [ ]Skipped Signed-off-by: Donghyeon Jeong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes refactoring the TensorV2 class to use a shared_ptr instead of a raw pointer for managing its TensorBase object. By adopting this change, we can improve the safety and reliability of our code and reduce the likelihood of memory leaks and other issues related to manual memory management.
Changes proposed in this PR:
Self-evaluation: