dist/Tizen: disable fp16 in Tizen

NNTrainer FP16 implementation relies on NEON, which requires armv8.2-a ISA. Tizen aarch64 is on armv8.0-a; thus it cannot support fp16-neon. Thus, disable fp16 in armv7l and aarch64. Tizen x86/x64 does not support fp16, too. This re-enabled Tizen build of nntrainer. Please do not break the build in main branch! Signed-off-by: MyungJoo Ham <[email protected]>
nnstreamer · Feb 2, 2024 · 59055e0 · 59055e0
1 parent 4cf814e
commit 59055e0
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/packaging/nntrainer.spec b/packaging/nntrainer.spec
@@ -47,10 +47,10 @@
 %endif # 0%{tizen_version_major}%{tizen_version_minor} >= 65
 
 %define enable_fp16 0
-%ifarch aarch64
-%define enable_fp16 1
-# x64/x86 requires GCC >= 12 for fp16 support.
-%endif
+### nntrainer fp16 implementation relies on NEON, which requires armv8.2-a
+### armv7l Tizen: do not support fp16 neon.
+### aarch64 Tizen: uses armv8.0a. no fp16 neon.
+### x86/x64 Tizen: it has gcc9. x86 requires gcc >= 12 for fp16
 
 ## Float16 support
 %if 0%{?enable_fp16}
@@ -563,6 +563,9 @@ cp -r result %{buildroot}%{_datadir}/nntrainer/unittest/
 %{_includedir}/nntrainer/util_func.h
 %{_includedir}/nntrainer/fp16.h
 %{_includedir}/nntrainer/util_simd.h
+%if 0%{?enable_fp16}
+%{_includedir}/nntrainer/util_simd_neon.h
+%endif
 
 %files devel-static
 %{_libdir}/libnntrainer*.a