Address some suggestions from Ruff and Pylint #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neuroevolutus
force-pushed
the
pylint-and-ruff-fixes
branch
2 times, most recently
from
acea843 to
569e601
Compare
neuroevolutus
force-pushed
the
pylint-and-ruff-fixes
branch
from
569e601 to
14d26ed
Compare
nlsandler
requested changes
Oct 24, 2024
gen_from_templates.py
Outdated
| @@ -7,6 +7,8 @@ | |||
| from string import ascii_lowercase | |||
| from typing import Any, Iterable | |||
|
|
|||
| import sys | |||
There was a problem hiding this comment.
Nitpicky comment: please add this line above "import textwrap" (to follow isort-recommended import order)
There was a problem hiding this comment.
Cool, will do.
The function was also renamed to `check_instructions`.
nlsandler
requested changes
Oct 28, 2024
nlsandler
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains some minor changes sourced from Ruff and Pylint. There should (hopefully) be no changes to the behavior of any of the files.