Improve test samples to catch more errors. #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is great, thank you! Thanks for flagging the issue in |
nlsandler
requested changes
Oct 28, 2024
|
As with the other PR, please feel free to make amendments. I think you have far better context for how the final change should look like. |
nlsandler
approved these changes
Oct 29, 2024
nlsandler
force-pushed
the
ysono/samples
branch
from
77532b1 to
39d874e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes some samples to correctly catch some errors as intended.
I edited
expected_results.jsonmanually, without runninggenerate_expected_results.py. Will.github/workflows/check_autogen_files.ymlrun for this PR?One thing I left untouched:
tests/chapter_6/valid/ternary_rh_binop.c: this test passes on solutions that prioritize either the logic or the conditional operator. Maybe using something other than||operator on the RHS would be better?