Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid Part II features in --int-only chapter 20 tests; better CI #37

Merged
merged 2 commits into from
Jul 9, 2024
Merged

Avoid Part II features in --int-only chapter 20 tests; better CI #37

merged 2 commits into from
Jul 9, 2024

Conversation

nlsandler
Copy link
Owner

@nlsandler nlsandler commented Jul 8, 2024 •
edited
Loading

Currently, testing chapter 20 with the --int-only option fails, because the util.h, which we use in both int-only and all-types tests, uses the double type.

This PR:

  • Updates CI to catch issues like this in future PRs
  • Splits util.h into two different headers

@nlsandler nlsandler marked this pull request as draft July 8, 2024 19:30
@nlsandler nlsandler force-pushed the int-only-fix branch 2 times, most recently from 6b25885 to 1cf1a88 Compare July 8, 2024 19:48
@nlsandler nlsandler changed the title add CI check to run test suite against each commit Avoid Part II features in --int-only chapter 20 tests; better CI Jul 9, 2024
@nlsandler nlsandler marked this pull request as ready for review July 9, 2024 00:10
@nlsandler nlsandler merged commit 914beab into main Jul 9, 2024
92 checks passed
@nlsandler nlsandler deleted the int-only-fix branch July 9, 2024 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nlsandler