Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: css asset href is relative #80

Merged
merged 2 commits into from
Jan 4, 2024
Merged

Conversation

edivados
Copy link
Contributor

@edivados edivados commented Jan 3, 2024

Solid-Start docs build would not load css.

We have to pass a / to joinURL when no baseURL is defined otherwise we end up with relative paths even if router.base is /.

The first arg of joinURL is the base.
https://github.com/unjs/ufo/blob/8638f512e3cd982699c9ccc6a3d8f6f010f4a35a/src/utils.ts#L178-L179

Did not touch the key prop as I am not sure about its usage.

Copy link

codesandbox bot commented Jan 3, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

changeset-bot bot commented Jan 3, 2024

🦋 Changeset detected

Latest commit: 6f695e2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 28 packages
Name Type
vinxi Patch
@vinxi/plugin-directives Patch
@vinxi/react-server Patch
@vinxi/router Patch
@vinxi/server-components Patch
@vinxi/server-functions Patch
example-react-server Patch
app Patch
example-react-spa-basic Patch
react-spa-mdx Patch
react-spa-tanstack-router-app Patch
example-react-spa-tanstack-router-app Patch
react-ssr-basic-cloudflare Patch
react-ssr-basic Patch
react-ssr-tanstack-router-app Patch
react-ssr-wouter Patch
solid-spa-basic Patch
solid-ssr-basic Patch
example-ssr-solid-router Patch
example-vanilla-empty Patch
example-vanilla-partyroom Patch
example-vanilla-spa Patch
example-vanilla-stack Patch
example-vanilla-trpc Patch
test-react-rsc Patch
test-react-srv-fn Patch
react-ssr-test-fs Patch
test-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vinxi-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 4, 2024 4:32am

@edivados edivados marked this pull request as draft January 3, 2024 15:45
@edivados edivados marked this pull request as ready for review January 3, 2024 15:52
@edivados edivados changed the title fix css asset href is relative fix: css asset href is relative Jan 3, 2024
@nksaraf nksaraf merged commit 6db755c into nksaraf:main Jan 4, 2024
6 checks passed
@edivados edivados deleted the css-asset-href branch January 4, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants