Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix): static assets imports in server side handler #52

Merged
merged 2 commits into from
Dec 27, 2023
Merged

Conversation

nksaraf
Copy link
Owner

@nksaraf nksaraf commented Dec 27, 2023

fixes #46

Copy link

codesandbox bot commented Dec 27, 2023

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

changeset-bot bot commented Dec 27, 2023

🦋 Changeset detected

Latest commit: 7af0a15

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 28 packages
Name Type
vinxi Patch
solid-ssr-basic Patch
@vinxi/plugin-directives Patch
@vinxi/react-server Patch
@vinxi/router Patch
@vinxi/server-components Patch
@vinxi/server-functions Patch
example-react-server Patch
app Patch
example-react-spa-basic Patch
react-spa-mdx Patch
react-spa-tanstack-router-app Patch
example-react-spa-tanstack-router-app Patch
react-ssr-basic-cloudflare Patch
react-ssr-basic Patch
react-ssr-tanstack-router-app Patch
react-ssr-wouter Patch
solid-spa-basic Patch
example-ssr-solid-router Patch
example-vanilla-empty Patch
example-vanilla-partyroom Patch
example-vanilla-spa Patch
example-vanilla-stack Patch
example-vanilla-trpc Patch
test-react-rsc Patch
test-react-srv-fn Patch
react-ssr-test-fs Patch
test-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vinxi-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 27, 2023 1:43pm

@nksaraf nksaraf merged commit 3459f3e into main Dec 27, 2023
5 checks passed
@nksaraf nksaraf deleted the static-imports branch December 27, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug?]: Static Asset Imports Do Not Work With SSR solidjs/solid-start#1182
1 participant