Merge pull request #53 from nksaraf/css-hmr

(fix): css hmr happens in vinxi/client for all css assets, not only for lazyRoutes
nksaraf · Dec 27, 2023 · b619909 · b619909
2 parents 3459f3e + a0974f0
commit b619909
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 9 deletions.
diff --git a/.changeset/fresh-peas-protect.md b/.changeset/fresh-peas-protect.md
@@ -0,0 +1,6 @@
+---
+"vinxi": patch
+"solid-spa-basic": patch
+---
+
+(fix): css hmr happens in vinxi/client for all css assets, not only for lazyRoutes
diff --git a/packages/vinxi/runtime/client.js b/packages/vinxi/runtime/client.js
@@ -7,4 +7,14 @@ if (import.meta.env.DEVTOOLS && import.meta.env.DEV) {
 	};
 }
 
+if (typeof window !== "undefined" && import.meta.hot) {
+	import.meta.hot.on("css-update", (data) => {
+		for (const el of document.querySelectorAll(
+			`style[data-vite-dev-id="${data.file}"]`,
+		)) {
+			el.innerHTML = data.contents;
+		}
+	});
+}
+
 globalThis.MANIFEST = manifest;
diff --git a/packages/vinxi/runtime/style.js b/packages/vinxi/runtime/style.js
@@ -1,7 +1,7 @@
 /**
- * 
- * @param {*} styles 
- * @param {*} data 
+ *
+ * @param {*} styles
+ * @param {*} data
  */
 export function updateStyles(styles, data) {
 	let styleAsset = styles.find(
@@ -10,12 +10,6 @@ export function updateStyles(styles, data) {
 	if (styleAsset) {
 		styleAsset.children = data.contents;
 	}
-
-	for (const el of document.querySelectorAll(
-		`style[data-vite-dev-id="${data.file}"]`,
-	)) {
-		el.innerHTML = data.contents;
-	}
 }
 
 export function appendStyles(styles) {