chore: create new ESLint config

nkowaokwu · Sep 26, 2024 · 0addd11 · 0addd11
1 parent 4bd21b3
commit 0addd11
Show file tree

Hide file tree

Showing 9 changed files with 32 additions and 123 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
diff --git a/@types/express.d.ts b/@types/express.d.ts
diff --git a/eslint.config.mjs b/eslint.config.mjs
@@ -0,0 +1,13 @@
+import globals from "globals";
+import pluginJs from "@eslint/js";
+import tseslint from "typescript-eslint";
+import pluginReact from "eslint-plugin-react";
+
+
+export default [
+  {files: ["**/*.{js,mjs,cjs,ts,jsx,tsx}"]},
+  {languageOptions: { globals: {...globals.browser, ...globals.node} }},
+  pluginJs.configs.recommended,
+  ...tseslint.configs.recommended,
+  pluginReact.configs.flat.recommended,
+];
diff --git a/functions/package.json b/functions/package.json
@@ -107,19 +107,9 @@
     "@types/string-similarity": "^4.0.0",
     "@types/supertest": "^6.0.2",
     "@types/uuid": "^9.0.2",
-    "@typescript-eslint/eslint-plugin": "^5.59.6",
-    "@typescript-eslint/parser": "^5.59.6",
     "cross-env": "^7.0.2",
     "cypress": "^12.14.0",
-    "eslint": "8.34.0",
-    "eslint-config-airbnb": "19.0.4",
-    "eslint-config-airbnb-typescript": "^17.0.0",
-    "eslint-config-next": "^14.1.0",
-    "eslint-config-prettier": "9.1.0",
-    "eslint-plugin-cypress": "2.12.1",
-    "eslint-plugin-import": "2.27.5",
-    "eslint-plugin-jsx-a11y": "6.7.1",
-    "eslint-plugin-react": "7.32.2",
+    "eslint": "9.11.1",
     "husky": "^4.3.0",
     "jest-environment-jsdom": "^29.7.0",
     "lint-staged": "^10.4.0",

diff --git a/package.json b/package.json
@@ -146,6 +146,7 @@
   "devDependencies": {
     "@commitlint/cli": "^11.0.0",
     "@commitlint/config-conventional": "^11.0.0",
+    "@eslint/js": "^9.11.1",
     "@semantic-release/changelog": "^5.0.1",
     "@semantic-release/commit-analyzer": "^8.0.1",
     "@semantic-release/git": "^9.0.0",
@@ -169,18 +170,10 @@
     "@types/string-similarity": "^4.0.0",
     "@types/supertest": "^6.0.2",
     "@types/uuid": "^9.0.2",
-    "@typescript-eslint/eslint-plugin": "^5.59.6",
-    "@typescript-eslint/parser": "^5.59.6",
     "cypress": "^12.14.0",
-    "eslint": "8.34.0",
-    "eslint-config-airbnb": "19.0.4",
-    "eslint-config-airbnb-typescript": "^17.0.0",
-    "eslint-config-next": "^14.1.0",
-    "eslint-config-prettier": "9.1.0",
-    "eslint-plugin-cypress": "2.12.1",
-    "eslint-plugin-import": "2.27.5",
-    "eslint-plugin-jsx-a11y": "6.7.1",
-    "eslint-plugin-react": "7.32.2",
+    "eslint": "^9.11.1",
+    "eslint-plugin-react": "^7.36.1",
+    "globals": "^15.9.0",
     "husky": "^4.3.0",
     "jest-environment-jsdom": "^29.7.0",
     "lint-staged": "^10.4.0",
@@ -190,7 +183,8 @@
     "prettier": "3.2.5",
     "supertest": "^6.3.1",
     "ts-jest": "^29.1.1",
-    "ts-node": "^10.9.2"
+    "ts-node": "^10.9.2",
+    "typescript-eslint": "^8.7.0"
   },
   "standard-version": {
     "skip": {

diff --git a/src/controllers/nsibidi.ts b/src/controllers/nsibidi.ts
@@ -1,13 +1,13 @@
 import { NextFunction, Response } from 'express';
 import mongoose, { Connection } from 'mongoose';
 import { handleQueries, packageResponse } from './utils';
-import { IgboAPIRequest } from '../types/express';
+import { IgboAPIRequest, MiddleWare } from '../types/express';
 import { searchNsibidiCharactersQuery } from './utils/queries';
 import { findNsibidiCharactersWithMatch } from './utils/buildDocs';
 import { nsibidiCharacterSchema } from '../models/NsibidiCharacter';
 import { NsibidiCharacter } from '../types/nsibidiCharacter';
 
-export const getNsibidiCharacters = async (req: IgboAPIRequest, res: Response, next: NextFunction) => {
+export const getNsibidiCharacters: MiddleWare = async (req, res, next) => {
   try {
     const { searchWord, version, skip, limit } = await handleQueries(req);
 
@@ -30,7 +30,7 @@ export const getNsibidiCharacters = async (req: IgboAPIRequest, res: Response, n
   }
 };
 
-export const getNsibidiCharacter = async (req: IgboAPIRequest, res: Response, next: NextFunction) => {
+export const getNsibidiCharacter: MiddleWare = async (req, res, next) => {
   try {
     const { id, version } = await handleQueries(req);
 

diff --git a/src/middleware/errorHandler.ts b/src/middleware/errorHandler.ts
@@ -1,7 +1,8 @@
 import { NextFunction, Request, Response } from 'express';
+import { ErrorMiddleWare } from '../types';
 
 // eslint-disable-next-line no-unused-vars
-export default (err: any, _: Request, res: Response, __: NextFunction) => {
+const errorHandler: ErrorMiddleWare = (err: any,  _, res, __) => {
   res.status(400);
   /* Depending on the nested error message the status code will change */
   if (err.message.match(/No .{1,} exist(s)?/) || err.message.match(/doesn't exist(s)?/)) {
@@ -10,3 +11,5 @@ export default (err: any, _: Request, res: Response, __: NextFunction) => {
   console.error(err?.stack);
   return res.send({ error: err.message });
 };
+
+export default errorHandler
diff --git a/src/types/express.ts b/src/types/express.ts
@@ -41,3 +41,7 @@ export interface IgboAPIRequest extends ExpressRequest {
 export interface MiddleWare {
   (req: IgboAPIRequest, res: Response, next: NextFunction): void;
 }
+
+export interface ErrorMiddleWare {
+  (error: any, req: IgboAPIRequest, res: Response, next: NextFunction): void;
+}
diff --git a/src/types/index.ts b/src/types/index.ts
@@ -1,4 +1,4 @@
-export type { MiddleWare, IgboAPIRequest, Query } from './express';
+export type { MiddleWare, ErrorMiddleWare, IgboAPIRequest, Query } from './express';
 export type { Developer, DeveloperDocument, DeveloperResponse } from './developer';
 export type {
   IncomingExample,