Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Allows AI to target ACE3 incapacitated enemies in CQB #391

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nk3nny
Copy link
Owner

@nk3nny nk3nny commented Mar 4, 2024

Potentially a controversial fix, but nonetheless grimly effective.

By allowing the AI to find and target ACE3 incapacitated enemies in CQB we FIX an inherent problem with the ACE3 system.

Even though the incapacitated unit is rendered invisible, the FSM on an engine level still "knows" there is something there. But because the unit is invisible, it will merely start faffing about. By allowing the AI to simply move there and kill the downed soldier, the problem resolves itself-- and the enemy becomes all the more deadly in CQB.

Being incapacitated outside of CQB range is unchanged (and players and AI will still survive).

Potentially a controversial fix, but nonetheless grimly effective.

By allowing the AI to find and target ACE3 incapacitated enemies in CQB we FIX an inherent problem with the ACE3 system.

Even though the incapacitated unit is rendered invisible, the FSM on an engine level still "knows" there is something there. But because the unit is invisible, it will merely start faffing about.

By allowing the AI to simply move there and kill the downed soldier, the problem resolves itself-- and the enemy becomes all the more deadly in CQB.

Being incapacitated outside of CQB range is unchanged (and players and AI will still survive)
@nk3nny nk3nny requested review from jokoho48 and diwako March 4, 2024 21:12
@nk3nny nk3nny self-assigned this Mar 4, 2024
@jokoho48
Copy link
Collaborator

jokoho48 commented Mar 4, 2024

This should probably be disabled by default, and/or we need to read out ace settings to check if an incapacitated unit can die because else we are back at the point of Mag Dumping into incapacitated players/units that cant die that we had before

@rekterakathom
Copy link
Contributor

If this gets added, I definitely agree with Joko that this should be disabled by default, I personally feel like AI magdumping unconscious people is very irritating, and deducts from gameplay. If an unconscious player gets magdumped, then any medical gameplay will just go out the window because nobody will bother healing anyone with 30 avulsions in their torso.

A3 2.18 will add a new command, ignoreTarget that could be a more elegant solution, perhaps give it a go on the dev branch?


// set incapacitated ACE units visible
if (!GVAR(disableIncapacitatedKills)) then {
private _vis = _target getVariable ["ace_common_oldVisibility", 1];
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure _target is local here? ace_common_oldVisibility is only available where _target is local, setUnitTrait also requires the _target to be local and will globally propagate the camouflage change.

@nk3nny nk3nny changed the title Allows AI to target ACE3 incapacitated enemies in CQB WIP: Allows AI to target ACE3 incapacitated enemies in CQB Jul 7, 2024
@nk3nny nk3nny marked this pull request as draft July 7, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants