Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add js_engine input test #38

Merged
merged 3 commits into from
Mar 19, 2024
Merged

Add js_engine input test #38

merged 3 commits into from
Mar 19, 2024

Conversation

nizarmah
Copy link
Owner

@nizarmah nizarmah commented Mar 19, 2024

Follow up for #37

Tests js_engine. Helps us ensure modification is performing as expected.

CI is enough

@nizarmah
Copy link
Owner Author

I forgot about the mangling part 🤔

That's going to make things much more difficult

@nizarmah
Copy link
Owner Author

Nevermind. I thought the mangle was random.
Turns out it's not. But it's very likely associated with the version used.

That's good to know.

I'm not going to automate updating the "expected" files right now.

The reason behind that decision is:

  • It's fairly easy to copy the expected output from the workflow logs
  • It's something we need to closely review to ensure the code is actually working

Copy link
Owner Author

@nizarmah nizarmah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good enough for now.

We can build it as we go.
Whenever a user opens an issue with some specific example, we can add the lines here to test for it.

@nizarmah nizarmah merged commit 6023eb0 into master Mar 19, 2024
6 checks passed
@nizarmah nizarmah deleted the test-js-engine-input branch March 19, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant