Improve test usage and clarity (#34)

nizarmah · Mar 17, 2024 · 225d1c6 · 225d1c6
1 parent b956ad1
commit 225d1c6
Show file tree

Hide file tree

Showing 8 changed files with 23 additions and 24 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -15,37 +15,36 @@ jobs:
       - name: Checkout the repository
         uses: actions/checkout@v4
 
-      - name: Targets specific directory
+      - name: Test on affected directory
         uses: ./
         with:
-          directory: "tests/action/directory/a/*"
+          directory: "tests/directory/affected/*"
 
-      - name: Compare the minified files
-        run: git diff --exit-code
+      - name: Assert not affected result does not exist
+        run: |
+          ! test -e tests/directory/not-affected/main.min.js
+
+      - name: Assert affected result matches expected
+        run: |
+          git diff --exit-code --no-index \
+            tests/directory/affected/main.expected.js \
+            tests/directory/affected/main.min.js
 
   overwrite:
     runs-on: ubuntu-latest
 
     steps:
       - name: Checkout the repository
         uses: actions/checkout@v4
-
-      - name: Test successful overwrite
-        uses: ./
-        with:
-          directory: "tests/action/overwrite/overwritten/*"
-          overwrite: true
-
-      - name: Assert successful overwrite
-        run: |
-          git diff --exit-code tests/action/overwrite/overwritten/*
-
-      - name: Test failed overwrite
+
+      - name: Test overwrite
         uses: ./
         with:
-          directory: "tests/action/overwrite/not-overwritten/*"
+          directory: "tests/overwrite/*"
           overwrite: true
 
-      - name: Assert failed overwrite
+      - name: Assert overwrite result matches expected
         run: |
-          ! git diff --exit-code tests/action/overwrite/not-overwritten/*
+          git diff --exit-code --no-index \
+            tests/overwrite/main.expected.js \
+            tests/overwrite/main.js
diff --git a/tests/action/directory/a/a.min.js b/tests/action/directory/a/a.min.js
diff --git a/tests/action/overwrite/overwritten/main.js b/tests/action/overwrite/overwritten/main.js
diff --git a/tests/directory/affected/main.expected.js b/tests/directory/affected/main.expected.js
diff --git a/tests/action/directory/b/b.js → tests/directory/affected/main.js b/tests/action/directory/b/b.js → tests/directory/affected/main.js
@@ -1,5 +1,5 @@
 function print_hello() {
-	console.log('hello world from b');
+	console.log('hello world from directory/affected');
 }
 
 window.addEventListener('load', function () {

diff --git a/.../action/overwrite/not-overwritten/main.js → tests/directory/not-affected/main.js b/.../action/overwrite/not-overwritten/main.js → tests/directory/not-affected/main.js
@@ -1,5 +1,5 @@
 function print_hello() {
-	console.log('hello world from overwrite/not-overwritten');
+	console.log('hello world from directory/not-affected');
 }
 
 window.addEventListener('load', function () {

diff --git a/tests/overwrite/main.expected.js b/tests/overwrite/main.expected.js
diff --git a/tests/action/directory/a/a.js → tests/overwrite/main.js b/tests/action/directory/a/a.js → tests/overwrite/main.js
@@ -1,5 +1,5 @@
 function print_hello() {
-	console.log('hello world from a');
+	console.log('hello world from overwrite');
 }
 
 window.addEventListener('load', function () {