Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix compilation with nix 2.25 #624

Merged
merged 2 commits into from
Nov 28, 2024
Merged

fix compilation with nix 2.25 #624

merged 2 commits into from
Nov 28, 2024

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Nov 23, 2024

No description provided.

@inclyc
Copy link
Member

inclyc commented Nov 23, 2024

nixt-nightly> ../test/Value.cpp:61:13: error: cannot convert 'NixInt' (aka 'Checked') to 'long' without a conversion operator

Looks like on macOS (libc++) it is long long 😢

libnixt/test/Value.cpp Outdated Show resolved Hide resolved
nixd/lib/Eval/AttrSetProvider.cpp Outdated Show resolved Hide resolved
nixd/lspserver/include/lspserver/Protocol.h Outdated Show resolved Hide resolved
flake.nix Outdated Show resolved Hide resolved
Mic92 and others added 2 commits November 27, 2024 21:38
on macOS `int64_t` is defined to `long long int` (not `long int`),
however LSP's JSON library (by llvm-project) only supports `std::int64_t`
@inclyc inclyc merged commit f12e2f7 into main Nov 28, 2024
19 checks passed
@inclyc inclyc deleted the nix-2.25 branch November 28, 2024 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants