Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixd/Controller: support "goto definition" for select expressions #549

Merged
merged 5 commits into from
Jul 26, 2024
Merged

nixd/Controller: support "goto definition" for select expressions #549

merged 5 commits into from
Jul 26, 2024

Conversation

inclyc
Copy link
Member

@inclyc inclyc commented Jul 23, 2024 •
edited
Loading

Add "goto definition" support for select expressions, e.g.

with pkgs; [
  nixVersions.nix
#              ^
]
pkgs.stdenv.mkDerivation
#            ^

These values are now "Ctrl + Click"-able to nixpkgs locations.

@inclyc inclyc force-pushed the nixd/Controller/definition/lambda-select branch from 220f86d to 14155ed Compare July 23, 2024 05:38
@inclyc inclyc changed the base branch from main to nixd/Eval/value-metadata July 23, 2024 05:38
@inclyc inclyc changed the title nixd/Controller/definition: handle select expressions nixd/Controller: support "goto definition" for select expressions Jul 23, 2024
Base automatically changed from nixd/Eval/value-metadata to main July 23, 2024 05:41
@inclyc inclyc force-pushed the nixd/Controller/definition/lambda-select branch from 14155ed to 61b4782 Compare July 23, 2024 05:41
inclyc added 2 commits July 25, 2024 09:21
@inclyc
nixd/Controller: support "goto definition" for select expressions
a40a881 
Enable "goto definition" for selection expressions like `lib.mkDefault` and `pkgs.nixd`.
@inclyc
tmp
3b1dfd4
@inclyc inclyc force-pushed the nixd/Controller/definition/lambda-select branch from 9214c93 to 3b1dfd4 Compare July 25, 2024 02:27
inclyc
inclyc commented Jul 25, 2024
View reviewed changes
nixd/lib/Controller/Completion.cpp Outdated Show resolved Hide resolved
nixd/lib/Controller/DocumentHighlight.cpp Outdated Show resolved Hide resolved
@inclyc inclyc marked this pull request as ready for review July 26, 2024 00:48
inclyc
inclyc commented Jul 26, 2024
View reviewed changes
Copy link
Member Author

@inclyc inclyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@inclyc inclyc added the enhancement New feature or request label Jul 26, 2024
@inclyc inclyc linked an issue Jul 26, 2024 that may be closed by this pull request
pkgs.‹name›could be assumed to point to a Nixpkgs package definition if the package‹name›exists. This is already done by e.g. thewith pkgs; [ … ]logic – it could be used for all variables namedpkgs` with an unknown definition, or just in cases that match the logic in heuristics 1 and 2? #552
Closed
@inclyc inclyc merged commit cee9c27 into main Jul 26, 2024
36 checks passed
@inclyc inclyc deleted the nixd/Controller/definition/lambda-select branch July 26, 2024 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@inclyc