Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixd: lib + pkgs completion with "select", e.g. lib.gen|, pkgs.stdenv.mkDerivat| #544

Merged
merged 1 commit into from
Jul 16, 2024
Merged

nixd: lib + pkgs completion with "select", e.g. lib.gen|, pkgs.stdenv.mkDerivat| #544

merged 1 commit into from
Jul 16, 2024

Conversation

inclyc
Copy link
Member

@inclyc inclyc commented Jul 16, 2024 •
edited
Loading

Fixes: #495

Screenshot_20240716_182427

@inclyc inclyc marked this pull request as draft July 16, 2024 05:51
inclyc
inclyc commented Jul 16, 2024
View reviewed changes
Copy link
Member Author

@inclyc inclyc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • cherry pick the first two commits to make the diff more concise
  • add tests

@inclyc inclyc force-pushed the nixd/lib-completion branch from 6eeb9ab to d0647d7 Compare July 16, 2024 14:19
@inclyc inclyc changed the title nixd: lib completion nixd: lib + pkgs completion with "select", e.g. lib.gen|, pkgs.stdenv.mkDerivat| Jul 16, 2024
inclyc
inclyc commented Jul 16, 2024
View reviewed changes
Copy link
Member Author

@inclyc inclyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial implementation.

  1. lib.| and pkgs.| does not work
  2. cannot handle with lib;
  3. cannot handle with expr + "select"
  4. cannot resolve function params

@inclyc inclyc force-pushed the nixd/lib-completion branch from d0647d7 to 2f2c80f Compare July 16, 2024 14:34
@inclyc inclyc added the enhancement New feature or request label Jul 16, 2024
@inclyc inclyc marked this pull request as ready for review July 16, 2024 14:35
inclyc
inclyc commented Jul 16, 2024
View reviewed changes
Copy link
Member Author

@inclyc inclyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's wait for github runners.

@inclyc inclyc merged commit 334da32 into main Jul 16, 2024
36 checks passed
@inclyc inclyc deleted the nixd/lib-completion branch July 16, 2024 14:38
@inclyc
Copy link
Member Author

inclyc commented Jul 17, 2024

Fixes #509

@inclyc inclyc mentioned this pull request Jul 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request nixd:controller
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support completions for lib
1 participant
@inclyc