Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixd/Controller: reply shutdown #502

Merged
merged 2 commits into from
May 20, 2024
Merged

nixd/Controller: reply shutdown #502

merged 2 commits into from
May 20, 2024

Conversation

inclyc
Copy link
Member

@inclyc inclyc commented May 18, 2024

No description provided.

@inclyc
Copy link
Member Author

inclyc commented May 18, 2024

shutdown was ignored before this commit. @Atemu could you confirm whether this PR fixes #499 ?

@inclyc inclyc linked an issue May 18, 2024 that may be closed by this pull request
Copy link

@Atemu Atemu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nixd now shuts down "cleanly" from eglot's perspective, thank you!

The exit signal is 9; not sure whether that's expected or not.

@inclyc
Copy link
Member Author

inclyc commented May 19, 2024

The exit signal is 9;

What did you mean by "exit signal"?

@Atemu
Copy link

Atemu commented May 19, 2024

Sorry, I meant exit code. it's just what eglot reports to me.

@inclyc
Copy link
Member Author

inclyc commented May 19, 2024

Sorry, I meant exit code. it's just what eglot reports to me.

No, the exit code should be 0 though. How about paste some logs here then?

@Atemu
Copy link

Atemu commented May 19, 2024

Actually, I have misread: It says "status 9", not "exit code":

[eglot] Asking EGLOT (nixfiles/(nix-mode)) politely to terminate
[jsonrpc] Server exited with status 9

It's the same status code when I exit haskell-language-server, so it's probably correct.

Getting logs is surprisingly hard because eglot justifyably clears all log buffers upon successful shutdown.

@inclyc inclyc merged commit ff3eb71 into main May 20, 2024
36 checks passed
@inclyc inclyc deleted the nixd/reply-shutdown branch May 20, 2024 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nixd dies on shutdown but not in the way eglot expects?
2 participants