update README for upstream mozilla-overlay issue #217
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resolution per comment mozilla/nixpkgs-mozilla#232 (comment)
|
What you wrote means inheriting no fields, not all of them, from the other attribute set, FYI. I recently made something that might help with the upstream issue, so I will leave a comment there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello all,
I recently followed the README to use a specific rust version with nixpkgs-mozilla overlay, and ran into an upstream error (
toRustTargetmissing) noted in the upstream issue mozilla/nixpkgs-mozilla#232.Reading this comment mozilla/nixpkgs-mozilla#232 (comment) it seems the solution is to inherit all packages from the chosen rustChannel, to avoid mixing overlay and non-overlay packages.
I'm a newbie when it comes to github contributions, so any advice is greatly appreciated.
Thanks 😃