Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(netlify-lambda): handle base64 encoded body #1940

Merged
merged 2 commits into from
Nov 28, 2023
Merged

fix(netlify-lambda): handle base64 encoded body #1940

merged 2 commits into from
Nov 28, 2023

Conversation

becem-gharbi
Copy link
Contributor

🔗 Linked issue

#1719

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This PR corrects encoding on netlify-lambda when posting base64 encoded body. It's similar to #1779.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0 pi0 changed the title fix(netlify-lambda): Handle base64 encoded body fix(netlify-lambda): handle base64 encoded body Nov 21, 2023
pi0
pi0 approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pi0 pi0 merged commit 7ae0bcd into nitrojs:main Nov 28, 2023
4 checks passed
@becem-gharbi becem-gharbi deleted the patch/netlify-base64 branch November 30, 2023 19:01
@Barbapapazes Barbapapazes mentioned this pull request Aug 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@becem-gharbi @pi0