Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New test CI attempting to use Github Actions #2837

Merged
merged 11 commits into from
Jun 27, 2024
Merged

Conversation

privat
Copy link
Member

@privat privat commented Jun 26, 2024

The script we used and that linked github repo and gitlab CI is broken, thanks to changes in both web api.
As maintaining this script is cumbersome, another option is to use Gitub Action that might be now more mature and usable in production.

This PR thus introduces a complete CI workflow with basic tests and a full matrix check.
All tests should run and be green, including weird ones that require neo4j, mongodb or various third parties libraries.

The main changes are:

  • disabling pug used in a few popcorn tests (2, the lowest value of few)
  • disabling android as the graddlew script need to be updated (and maybe more work is required)
  • disabling some actor examples (to investigate)

@privat privat force-pushed the test-ci branch 2 times, most recently from 06b3082 to 9f029db Compare June 26, 2024 14:54
@privat
Copy link
Member Author

privat commented Jun 26, 2024

All green after 5h of CPU time 🎉

.github/workflows/makefile.yml Outdated Show resolved Hide resolved
.github/workflows/makefile.yml Outdated Show resolved Hide resolved
.github/workflows/makefile.yml Outdated Show resolved Hide resolved
.github/workflows/makefile.yml Outdated Show resolved Hide resolved
.github/workflows/makefile.yml Outdated Show resolved Hide resolved
@privat
Copy link
Member Author

privat commented Jun 27, 2024

Ok, I played more with the CI to solve the forked repo issue.
Basically, it needs two components :

  • the workflow on the pr with read-only privilege, that produce artifacts
  • the workflow on the master branch with write privilege that read the produced artifacts of produce reports and update the status of the PR

This also have the advantage of having a single big report instead of a small one per job.

The main drawback (for now) is that while the PR provide both workflow, only the PR one is run as the master one is not installed (yet). It will be once (if) the PR is merged.
However, I did install it in my fork, so we can see some results here: privat#5

@privat privat merged commit 3129423 into nitlang:master Jun 27, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants