lib/markdown2: introduce a new Markdown engine #2720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandre Terrasa <[email protected]>
Signed-off-by: Alexandre Terrasa <[email protected]>
Signed-off-by: Alexandre Terrasa <[email protected]>
Signed-off-by: Alexandre Terrasa <[email protected]>
Signed-off-by: Alexandre Terrasa <[email protected]>
Signed-off-by: Alexandre Terrasa <[email protected]>
Signed-off-by: Alexandre Terrasa <[email protected]>
Signed-off-by: Alexandre Terrasa <[email protected]>
Signed-off-by: Alexandre Terrasa <[email protected]>
Signed-off-by: Alexandre Terrasa <[email protected]>
Signed-off-by: Alexandre Terrasa <[email protected]>
Signed-off-by: Alexandre Terrasa <[email protected]>
Signed-off-by: Alexandre Terrasa <[email protected]>
Signed-off-by: Alexandre Terrasa <[email protected]>
Signed-off-by: Alexandre Terrasa <[email protected]>
Signed-off-by: Alexandre Terrasa <[email protected]>
Signed-off-by: Alexandre Terrasa <[email protected]>
|
test this please |
|
Tests are ok, the "location marker" found by check whitespace is a Markdown setext header: My Heading
========= |
privat
added a commit
that referenced
this pull request
Jun 26, 2018
This PR introduces a new Markdown engine called `markdown2`. The current Markdown implementation is functional but does not follows the [CommonMark](http://commonmark.org/) specification as it passes only 273 tests of the 627 from the [CommonMark test suite](https://github.com/CommonMark/CommonMark). Also there is a few issues with it as stated in #791, #1394, #1525 and #2507. This new implementation aims at resolving these issues and follow the CommonMark specification. Features: * Markdown AST creation and rendering * Rendering to HTML * Rendering to Markdown * Rendering to Man format * Rendering to LaTeX * Parsing of Github extended mode * Parsing of wikilinks * Parsing of LaTeX/Maths expression (upcoming in next PR) * Respect of the CommonMark specification with only 10 tests failed (UTF-8 related) * Extensive testing with a total of 980 test units... I didn't remove the old markdown implementation since the benchmarks are not really good for now. Since `markdown2` uses a lot of regular expressions, performances can be an issue compared to `markdown`:  In the following PR some Nit tools will be migrated to the new implementation: * nitunit * nitiwiki * nitdoc * nitweb Pull-Request: #2720
privat
approved these changes
Jun 27, 2018
| redef fun parent do return super | ||
|
|
||
| # Can this block contain other blocks? | ||
| var is_container = false |
There was a problem hiding this comment.
shouldn't is_container be a function?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new Markdown engine called
markdown2.The current Markdown implementation is functional but does not follows the CommonMark specification as it passes only 273 tests of the 627 from the CommonMark test suite.
Also there is a few issues with it as stated in #791, #1394, #1525 and #2507.
This new implementation aims at resolving these issues and follow the CommonMark specification.
Features:
I didn't remove the old markdown implementation since the benchmarks are not really good for now. Since
markdown2uses a lot of regular expressions, performances can be an issue compared tomarkdown:In the following PR some Nit tools will be migrated to the new implementation: