json::serialization: fix reading attributes from non-objects #2295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexis Laferrière <[email protected]>
|
tests! |
|
@privat I'll write tests if you fix nitunit so I can use it in |
|
I still get the same error: |
|
This is a different error. Some path confusion for the inability of nitunit to explain the loader how to find the tested module. Can you copy-paste into a distinct issue so we can merge the PR? |
|
+1 by the way :) |
|
+1 |
1 similar comment
|
+1 |
|
See issue #2296. |
privat
added a commit
that referenced
this pull request
Aug 26, 2016
This error could arise when parsing invalid JSON strings (or non-object JSON values) and skipping the call to `deserialize`. See @privat comment in #2291. Pull-Request: #2295 Reviewed-by: Jean Privat <[email protected]> Reviewed-by: Lucas Bajolet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This error could arise when parsing invalid JSON strings (or non-object JSON values) and skipping the call to
deserialize.See @privat comment in #2291.