Add: Sass Support with Generators and CSS Variables #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nisheed2440
reviewed
Jul 29, 2019
| }, | ||
| ], | ||
| }); | ||
| // create your generators here |
There was a problem hiding this comment.
The file tab spacing seems to contradict the the prettier config i had locally. Could you add tab spaces 2 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Readme.mdandChangelog.md@nisheed2440 Let me know your thoughts to this, I would quite like this merged in and think it would be helpful for those of us with existing Sass libraries.
Possible improvement I'll make in a future PR is to generate a Sass globals file which adds CSS Variables to the
:rootscope.