Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/valgrind-async-disaptch-threadpool-failure #10

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

noahehall
Copy link
Contributor

@noahehall noahehall commented Mar 15, 2023

  • simplify the code to its most basic form and build up from there; adding useMalloc didnt resolve the issue

    • start with a file that just includes asyncdispatch & threadpool
    • incrementally add the existing logic to see why exactly this throws
      • its weird because the only thing we're doing is importing asyncdispatch and threadpool
  • if you run tconfig via nim c instead of testament all you get a bunch of warnings

/home/runner/work/nightlies/nightlies/nim-1.6.12/compiler/sempass2.nim(209, 10) 
compiler msg initiated here [MsgOrigin]

/home/poop/git/private/nirv/boat/tests/config/tconfig.nim(21, 32)
Warning: not GC-safe: 'proc (): auto = result = save(newConf(newConfig(), defaultManifest), "")' 
[GcUnsafe]
    it should, "save config", () => newConf().save()

@noahehall noahehall force-pushed the bug/valgrind-fails-on-asyncdispatch-and-threadpool-import branch from a3e67a1 to 442d971 Compare March 15, 2023 16:54
@noahehall noahehall force-pushed the bug/valgrind-fails-on-asyncdispatch-and-threadpool-import branch from be8ea1f to 13a9d15 Compare March 15, 2023 17:04
@noahehall noahehall force-pushed the bug/valgrind-fails-on-asyncdispatch-and-threadpool-import branch from bf88f65 to 9e508ef Compare March 15, 2023 21:42
@noahehall noahehall force-pushed the manifest branch 19 times, most recently from adfcc6d to a958e3b Compare March 16, 2023 23:42
Base automatically changed from manifest to develop March 16, 2023 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant