Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was made during the 2024 BIDS meeting in Seattle after discussions with @effigies, some other discussions can be found here #bids-standard/BEP028_BIDSprov#129
BEP028_prov doc see here
Types of changes
context.json
filewasStartedBy
,wasEndedBy
, andhadActivity
.audit.py
but not defined in the prov context. Those are important for connectingaudit_start
,monitor
, andfinalize_audit
.audit_start
,monitor
, andfinalize_audit
as subactivities of the activity of a given task, the current BEP028 doesn't define the connection between activities but only allows connecting two activities through entities.audit.py
startedAtTime
asStartedAtTime
entity_generated
, replaced it with a more specific field; in this case isruntime
but it can be something else depending on the situation.entity_generated
can be confused withentity
in the prov doc, which is supposed to be either input files or output files related to an activity."AssociatedWith": version_cmd
toa dictionary, which is supposed to be an
Agent
, but I couldn't get theLabel
, which isName of the software
command
, currently we only get command when the task is a shell command task. If we want to be consistent with the prov, we probably should enable command for function tasks too. See the anonymous (that's Chris) comment on the prov doc.Summary
so the above changes are based on what we have in the prov doc, we probably need to dive deeper into
audit.py
andmessenger.py
(worth discussing in the next pydra meeting @djarecka)@effigies suggested we collect messages for a workflow to generate prov records.
for example, we can collect all messages at
finalize_audit
level intoFileMessenger
usingcollect_messages
Checklist