FIX: Postpone coordinate mapping on linear array transforms #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oesteban
force-pushed
the
fix/memory-issues-173
branch
from
90df2f7 to
db1b250
Compare
effigies
reviewed
Nov 16, 2023
oesteban
commented
Nov 16, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #187 +/- ##
==========================================
+ Coverage 96.97% 97.06% +0.08%
==========================================
Files 13 13
Lines 1289 1294 +5
Branches 252 251 -1
==========================================
+ Hits 1250 1256 +6
Misses 33 33
+ Partials 6 5 -1 ☔ View full report in Codecov by Sentry. |
oesteban
force-pushed
the
fix/memory-issues-173
branch
from
8b21efa to
616ee06
Compare
oesteban
force-pushed
the
fix/memory-issues-173
branch
from
616ee06 to
40e3c13
Compare
|
@arokem this should solve the issue we were having in eddymotion before Summer |
oesteban
commented
Nov 16, 2023
oesteban
force-pushed
the
fix/memory-issues-173
branch
from
aaa69dd to
9bd0c59
Compare
Co-authored-by: Chris Markiewicz <[email protected]>
oesteban
force-pushed
the
fix/memory-issues-173
branch
from
9bd0c59 to
d148e85
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR transforms the coordinates of the reference into the moving image for each timepoint separately, effectively minimizing the memory footprint.
Resolves: #173.