Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "ENH: Add writer for Siemens CSA header" #1347

Merged
merged 1 commit into from
Sep 7, 2024

Conversation

effigies
Copy link
Member

@effigies effigies commented Sep 7, 2024

Undefined names are found in this function. Fixes are not obvious enough for me to resolve.

Reverts #417

cc @moloney

@effigies effigies merged commit f3c2168 into master Sep 7, 2024
2 checks passed
Copy link

codecov bot commented Sep 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.34%. Comparing base (09d3f95) to head (032f6df).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1347      +/-   ##
==========================================
+ Coverage   95.32%   95.34%   +0.02%     
==========================================
  Files         207      207              
  Lines       29562    29507      -55     
  Branches     4996     4982      -14     
==========================================
- Hits        28180    28134      -46     
+ Misses        938      932       -6     
+ Partials      444      441       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies effigies deleted the revert-417-enh-csa-write branch September 8, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant