Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to review auto version -v output during release + adjust that workflow step description #743

Merged
merged 5 commits into from
Feb 26, 2024

Conversation

yarikoptic
Copy link
Member

No description provided.

@yarikoptic yarikoptic added the internal Changes only affect the internal API label Feb 26, 2024
@yarikoptic yarikoptic requested a review from jwodder February 26, 2024 14:21
.github/workflows/release.yml Outdated Show resolved Hide resolved
version="$(~/auto version)"
# to be able to debug if something goes wrong
auto version -v | tee /tmp/auto-version
version="$(tail -n 1 /tmp/auto-version)"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure the version is always the last line?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not 100% -- but on my test run it was.

ok -- let's try another way:

sed -ne '/Calculated SEMVER bump:/s,.*: *,,p' < /tmp/auto-version

will push now...

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.05%. Comparing base (7b98ae7) to head (17aad35).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #743   +/-   ##
=======================================
  Coverage   82.05%   82.05%           
=======================================
  Files          41       41           
  Lines        4173     4173           
=======================================
  Hits         3424     3424           
  Misses        749      749           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yarikoptic yarikoptic requested a review from jwodder February 26, 2024 17:47
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
@yarikoptic yarikoptic requested a review from jwodder February 26, 2024 17:55
@yarikoptic yarikoptic added the release Create a release when this pr is merged label Feb 26, 2024
@yarikoptic yarikoptic merged commit 4518a54 into nipy:master Feb 26, 2024
10 checks passed
Copy link

🚀 PR was released in v1.0.2 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Changes only affect the internal API release Create a release when this pr is merged released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants