Barebones grpc aio attempt #276
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nipunn1313
commented
Aug 18, 2021
| ) -> typing.Awaitable[global___DummyReply]: ... | ||
|
|
||
|
|
||
| def add_DummyAsyncServiceServicer_to_server(servicer: DummyAsyncServiceServicer, server: grpc.Server) -> None: ... |
There was a problem hiding this comment.
should be server: grpc.aio.Server - but held off on that change until some minimal stub gets into grpc-stubs
| @abc.abstractmethod | ||
| def UnaryUnary(self, | ||
| request: global___DummyRequest, | ||
| context: grpc.ServicerContext, |
There was a problem hiding this comment.
I suppose we'd want two separate ServicerContext here - depending on whether it's a synchronous service or not - but that's out of my realm of expertise.
Open
|
closing based on conversation in #217 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
put together a bare diff with ideas from #217 - might be a good starting point for @MHDante 's idea