Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add t2w_file output to TemplateFlowSelect #457

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

mgxd
Copy link
Collaborator

@mgxd mgxd commented Dec 11, 2024

If found, great. If not, just returns Undefined.

@mgxd mgxd force-pushed the enh/templateselect branch from bbd0faf to f260c49 Compare December 11, 2024 05:09
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.05%. Comparing base (bef4e76) to head (f260c49).
Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #457       +/-   ##
===========================================
+ Coverage   66.71%   77.05%   +10.34%     
===========================================
  Files          31       31               
  Lines        2076     2079        +3     
  Branches      246      205       -41     
===========================================
+ Hits         1385     1602      +217     
+ Misses        689      447      -242     
- Partials        2       30       +28     
Flag Coverage Δ
ds054 45.79% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with this, since it looks the same as the lines just above. Posted question that I hope isn't a rabbit hole pre-review.

@mgxd mgxd merged commit e2f720d into nipreps:master Dec 11, 2024
17 checks passed
@mgxd mgxd deleted the enh/templateselect branch December 11, 2024 20:44
effigies added a commit that referenced this pull request Dec 19, 2024
0.17.0 (December 19, 2024)

New feature release in the 0.17.x series.

This release improves handling of datasets where T1w images are not
the primary modality. It also supports the generation of fsLR meshes
on the subject surface with the names:

    sub-<label>/anat/sub-<label>_hemi-<L|R>_space-fsLR_den-<label>_<surface>.surf.gii

These are useful for plotting CIFTI results on subject anatomy.

* FIX: Stop excluding FS minc_modify_header used during fallback registration (#453)
* ENH: Output fsLR meshes on subject surfaces (#460)
* ENH: Support spatial normalization to alternative modalities (#459)
* ENH: Add `t2w_file` output to `TemplateFlowSelect` (#457)
* MNT: Enable pre-release tests (#461)
* MNT: Complete transition from flake8/black to ruff (#435)
* MNT: Adopt src/ layout and tox (#458)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants