Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Remove accidental MRIQC dependency, allow app config to be passed to workflow plugin #876

Merged
merged 3 commits into from
Jun 21, 2024

Conversation

effigies
Copy link
Member

@effigies effigies commented Jun 20, 2024

Reverted some uses of config to the nipype config, which an app should generally be injecting into the nipype workflow config.

Some parts don't exist, so I'm allowing an app config to be passed as a plugin argument "app_config", and falling back to nipype defaults or trivial replacements.

Closes #875.

Copy link
Contributor

@mgxd mgxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hah i was just working on this - LGTM

niworkflows/engine/tests/test_plugin.py Outdated Show resolved Hide resolved
@mgxd mgxd merged commit 44814ec into nipreps:master Jun 21, 2024
25 checks passed
@effigies effigies deleted the fix/nipype-plugin branch June 21, 2024 00:56
mgxd added a commit that referenced this pull request Jul 31, 2024
1.11.0 (July 31, 2024)

New minor release to start the 1.11.x series.

The major changes include:
- a deprecation to T1w-only based template processing
- addition of a new dependency ``acres`` for accessing package data

However, this is still backwards compatible with the 1.10.x series.

* MAINT: Depend on acres for data access
* ENH: Add PrepareDerivative/SaveDerivative interfaces (#885)
* ENH: Make template dimensions support T2w as well (#879)
* ENH: Modify FSSource to output T2 (#868)
* FIX: Set cal_max in the NIfTI header for visualization after ``IntensityClip`` (#878)
* FIX: Remove accidental MRIQC dependency, allow app config to be passed to workflow plugin (#876)
* TEST: Fix plugin invocation, use an initializer that can be verified (#880)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mriqc not installed as dependency
2 participants