FIX: Copy header to ensure mask is really aligned #844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #844 +/- ##
=======================================
Coverage 60.96% 60.96%
=======================================
Files 55 55
Lines 6558 6558
Branches 954 954
=======================================
Hits 3998 3998
Misses 2374 2374
Partials 186 186
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@oesteban Any objection? |
oesteban
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For reasons I don't fully understand, the transformation of a template mask for N4 correction could sometimes end up with different qforms and sforms from the reference image. Our attempt to fix up the headers was insufficient, so I'm just copying the whole thing. This fixes the issue, and this image isn't going to be reused in any other context, so the preservation of other header fields seems irrelevant.