Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add MRIQC's custom multiproc runner that allows passing the pool #841

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

oesteban
Copy link
Member

@oesteban oesteban commented Dec 4, 2023

This is useful to minimize the workers' fingerprint.

@oesteban oesteban force-pushed the enh/multiproc-pass-pool branch from 06954a5 to 91aa5d9 Compare December 4, 2023 11:19
@effigies
Copy link
Member

effigies commented Dec 4, 2023

Is there a reason not to contribute this upstream to nipype?

Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Attention: 263 lines in your changes are missing coverage. Please review.

Comparison is base (16609f2) 63.36% compared to head (91aa5d9) 61.05%.
Report is 2 commits behind head on master.

Files Patch % Lines
niworkflows/engine/plugin.py 13.48% 263 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #841      +/-   ##
==========================================
- Coverage   63.36%   61.05%   -2.32%     
==========================================
  Files          53       54       +1     
  Lines        6238     6542     +304     
  Branches      907      952      +45     
==========================================
+ Hits         3953     3994      +41     
- Misses       2099     2362     +263     
  Partials      186      186              
Flag Coverage Δ
reportlettests ∅ <ø> (∅)
unittests ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oesteban
Copy link
Member Author

oesteban commented Dec 4, 2023

Is there a reason not to contribute this upstream to nipype?

None - just my laziness and reducing the maintenance effort of nipype.

There's a quasi-reason in the sense that I had the plan to write a plugin based on asyncio and test it with MRIQC, and this was like the first tiny test of a drop-in plugin implementation.

Can we merge this in here to speed up the deployment of sdcflows (which uses this, so we can test), and at the same time I'll send a PR to nipype?

@effigies
Copy link
Member

effigies commented Dec 4, 2023

Sure

@oesteban oesteban merged commit 546f143 into master Dec 4, 2023
42 of 43 checks passed
@oesteban oesteban deleted the enh/multiproc-pass-pool branch December 4, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants