Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ignore_initial_volumes param to ConfoundsCorrelationPlot #83

Merged
merged 4 commits into from
Dec 12, 2023

Conversation

tsalo
Copy link
Contributor

@tsalo tsalo commented Dec 11, 2023

Related to nipreps/niworkflows#843.

Changes proposed:

  • Add an ignore_initial_volumes parameter to the ConfoundsCorrelationPlot interface.
  • Add an ignore_initial_volumes parameter to the confounds_correlation_plot function.

@effigies
Copy link
Member

How tough do you think it would be to add a unit test?

Copy link

codecov bot commented Dec 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (01e9a93) 54.28% compared to head (65f5b01) 57.02%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #83      +/-   ##
==========================================
+ Coverage   54.28%   57.02%   +2.74%     
==========================================
  Files          22       22              
  Lines        2019     2020       +1     
  Branches      391      391              
==========================================
+ Hits         1096     1152      +56     
+ Misses        845      787      -58     
- Partials       78       81       +3     
Flag Coverage Δ
unittests 57.02% <100.00%> (+2.74%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsalo
Copy link
Contributor Author

tsalo commented Dec 11, 2023

I think I can just copy over the unit tests from niworkflows, so probably not too hard. I'll try to do it by EOD.

nireports/tests/test_interfaces.py Show resolved Hide resolved
nireports/tests/test_interfaces.py Outdated Show resolved Hide resolved
Co-authored-by: Chris Markiewicz <[email protected]>
@effigies effigies merged commit 239a501 into nipreps:main Dec 12, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants