OSX fix joining main thread with calling thread when exiting #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I totally missed that. Nice find. Will see if I can try it tomorrow. |
brainstormi
changed the title
|
I don't think I will have time today. I will get back to you. Thanks! |
Serneum
pushed a commit
to Serneum/esdl2
that referenced
this pull request
Aug 30, 2016
Serneum
pushed a commit
to Serneum/esdl2
that referenced
this pull request
Aug 30, 2016
Serneum
pushed a commit
to Serneum/esdl2
that referenced
this pull request
Sep 13, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current commit fixes a segfault when terminating the app in OSX.
Continue to be issues with dtor_Texture that generates a different segfault in current demos, so to be able to replicate the segfault fixed by this commit, limit the code to create a window and exit.
On OSX we have to use erl_drv_steal_main_thread, a not documented function to run SDL2 in main thread. In the same way, to join it again with the calling thread when exiting, we have to invoke erl_drv_stolen_main_thread_join instead of enif_thread_join like in Windows/Linux.