-
-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#970 - Allow for additional template Modifiers #983
base: master
Are you sure you want to change the base?
Conversation
90a238b
to
cf901e7
Compare
Please also rebase this one. |
* Templates now exist under templates/ * Templates can now have a directory and extension defined * Added hrl template * Updated supervisor template to include Child Specs * Made some bootstrap templates generateable via new
cf901e7
to
9623a10
Compare
@essen rebased this one 👍 |
Thank you! |
I think I would take a different approach. It would be good if template files were completely outside of Makefiles in the Erlang.mk source, as well as in third party plugins. This would make editing and testing them simpler. Of course the compiled Erlang.mk file should include them inside the file, not separately. So it all comes down to being able to declare templates that will be loaded from a file if the corresponding variable doesn't exist, and making the Erlang.mk build embed the files inside variables. If templates become core functionality, then the entire bootstrap plugin probably should be core as well. Not much remains. I will work on something. |
I have opened #1013 for my version of the thing. Almost all templates including internal have been replaced. Makefiles remain. Some plain substitution happens for module names and whatnot. Erlang.mk still embeds templates but it's possible to use By the way do you remember why you moved them to core? |
I have merged my changes: a6f9a45 When you have time, please add the additional templates and template fixes you included in this PR or were thinking of including. |
Implements #970