[WIP] feat: improve validator fetch logic #194
+48
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onmax
changed the title
onmax
force-pushed
the
onmax/validators-api-fetcher
branch
from
e71cef3
to
78ccb1a
Compare
sisou
reviewed
Nov 20, 2024
|
|
||
| return { | ||
| src: 'logoPath' in props.validator | ||
| ? `${config.staking.validatorsEndpoint}}/${props.validator.logoPath}` : undefined, |
There was a problem hiding this comment.
Is this deployed to validator-api yet? Or should we keep the fallback of logo?
sisou
reviewed
Nov 20, 2024
onmax
commented
Nov 20, 2024
| <circle cx="8.25" cy="8.25" r="4.5" fill="none" stroke="#000" stroke-linecap="round" stroke-linejoin="round" stroke-width="3.0"/> | ||
| <line x1="16.25" y1="16.25" x2="11.75" y2="11.75" fill="none" stroke="#000" stroke-linecap="round" stroke-linejoin="round" stroke-width="3.0"/> | ||
| <circle cx="8.25" cy="8.25" r="4.5" fill="none" stroke="currentColor" stroke-linecap="round" stroke-linejoin="round" stroke-width="3.0"/> | ||
| <line x1="16.25" y1="16.25" x2="11.75" y2="11.75" fill="none" stroke="currentColor" stroke-linecap="round" stroke-linejoin="round" stroke-width="3.0"/> |
There was a problem hiding this comment.
we use this component in two places
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We load the validators api in two occasions:
launchNetworkThe webclient when we subscribe to blocks, some of them will be on already ended epochs, so the wallet will update the epoch number two times.