-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for SINPE Movil #163
Open
onmax
wants to merge
46
commits into
master
Choose a base branch
from
onmax/sinpe
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onmax
force-pushed
the
onmax/sinpe
branch
6 times, most recently
from
June 17, 2024 09:34
370d9a6
to
b587054
Compare
sisou
force-pushed
the
onmax/sinpe
branch
2 times, most recently
from
August 13, 2024 15:58
f10ad4a
to
9269125
Compare
This is not a breaking change, and it will help us ensure the string values are consintent across the app
This commit does not add support per sé, but rather the helper functions to build the swap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What to Review?
useSinpeMovil
composable with all the logicAssetTransfer
will all the templating and some logic for swaps that include FIAT. In the future, if we need to implement a swap, we would just need to create a new composable very similar touseSinpeMovil
RouteName
enum for routes app-wide to avoid using raw strings. This is not a breaking change. It is more like adding TS to the routes so we have better DXTODO
package.json
Related PR
Changelog
AssetTransfer
: A component that will consume a composable that have all the required data for the swap. So UI and logic are divided.SwapAsset.CRC
andSwapAsset.LBTC
, which has been added to the oasis lib-Hub and keyguard updated. Keyguard also includes new designs for Sinpe Movil.