Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix max-len warning in WalletInfoCollector.ts #554

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix max-len warning in WalletInfoCollector.ts #554

wants to merge 1 commit into from

Conversation

mraveux
Copy link
Member

@mraveux mraveux commented Nov 27, 2024

No description provided.

@danimoh
Copy link
Member

danimoh commented Nov 27, 2024

I think this one should not be merged / not yet.
Rather, if our updates make syncing sufficiently quick again, I would revert the change that commented out the original code, and double-commented these lines, causing them to get too long.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danimoh danimoh Awaiting requested review from danimoh

@sisou sisou Awaiting requested review from sisou

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mraveux @danimoh