Intern BLS lazy public keys #3141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrxi
force-pushed
the
hrxi/intern_bls
branch
from
f245572
to
a64ae0e
Compare
paberr
reviewed
Nov 24, 2024
hrxi
force-pushed
the
hrxi/intern_bls
branch
4 times, most recently
from
d3659f6
to
f01a778
Compare
Did so, resulted in a much nicer API. :) |
hrxi
force-pushed
the
hrxi/intern_bls
branch
from
f01a778
to
062b8af
Compare
jsdanielh
reviewed
Nov 26, 2024
|
Also it looks like there are untouched filed with clippy warnings |
|
With this changes, in Safari we get consensus in ~12secs Previously, in Safari, we used to get consensus in ~23secs |
hrxi
force-pushed
the
hrxi/intern_bls
branch
from
062b8af
to
fea8c7e
Compare
Fixed. |
hrxi
force-pushed
the
hrxi/intern_bls
branch
from
fea8c7e
to
5438dec
Compare
This ensures that for each compressed public key there's at most one lazy public key, which means everyone profits when it is uncompressed. This drops the (unused: never read from) BLS public key cache.
jsdanielh
force-pushed
the
hrxi/intern_bls
branch
from
5438dec
to
6b3a3e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that for each compressed public key there's at most one lazy public key, which means everyone profits when it is uncompressed.
This drops the (unused: never read from) BLS public key cache.