Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

break some things #1

Open
wants to merge 8 commits into
base: github-actions
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 7 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions .github/workflows/quick-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
uses: actions/checkout@v2
with:
path: 'gwt'
fetch-depth: 2
fetch-depth: 0
- name: Checkout GWT tools into a sibling directory
uses: actions/checkout@v2
with:
Expand All @@ -28,6 +28,7 @@ jobs:
- name: Build, test, produce docs
# Presently this runs no tests at all, but could
run: |
set -eux
cd gwt
# Set env vars to ensure we get the build we expect
export \
Expand All @@ -46,11 +47,15 @@ jobs:
env:
REVIEWDOG_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
cd gwt
for xml in $(find build/out | grep checkstyle); do
reviewdog -f=checkstyle -reporter=local -level=info -diff="git diff ${{github.event.pull_request.base.sha}}"< $xml
reviewdog -f=checkstyle -reporter=github-pr-review -level=info < $xml
done
set -eux
cd gwt
git log --graph --oneline --decorate --stat ${{github.event.pull_request.base.sha}}..HEAD
git diff ${{github.event.pull_request.base.sha}}
for xml in $(find build/out | grep checkstyle); do
echo $xml
reviewdog -tee -f=checkstyle -filter-mode=diff_context -reporter=local -level=info -diff="git diff ${{github.event.pull_request.base.sha}}" < $xml
reviewdog -tee -f=checkstyle -filter-mode=diff_context -reporter=github-pr-review -level=info < $xml
done
- name: Upload checkstyle xml for manual review
uses: actions/upload-artifact@v2
if: always()
Expand Down
8 changes: 7 additions & 1 deletion dev/core/super/com/google/gwt/core/client/GwtScriptOnly.java
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,10 @@
package com.google.gwt.core.client;

import java.lang.annotation.Documented;
import java.lang.annotation.ElementType;
import java.lang.annotation.Target;

import java.lang.annotation.ElementType;

/**
* This annotation is used to break out of a module's source path in hosted
* mode. Types annotated with this annotation will not be loaded by hosted
Expand All @@ -41,4 +42,9 @@
@Target({ElementType.TYPE, ElementType.METHOD})
@Deprecated
public @interface GwtScriptOnly {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.RegexpCheck> reported by reviewdog 🐶
Line matches the illegal pattern 'more than one blank line'.




}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.RegexpCheck> reported by reviewdog 🐶
Line matches the illegal pattern 'more than one blank line'.