Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISOLA 1024 Points #54

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

ISOLA 1024 Points #54

wants to merge 9 commits into from

Conversation

fanisvl
Copy link

@fanisvl fanisvl commented Aug 26, 2024

ref. #53

Hello,

I made the necessary changes to set NUM_OF_TIME_SAMPLES from 8192 points to 1024.

I did some testing and inversions are indeed faster:

8192.log
INFO Function 'calculateInversions' executed 278.77 seconds
1024.log
INFO Function 'calculateInversions' executed 31.76 seconds

8192.log

1024.log

Do note that there's still some comments that reference 8192 points, in src/config.yaml

  .... 
  # For example, if 4.0<= Mag <=4.5, Gisola will use 245.76 sec as
  # inversion time window. Values, that can be used must be able
  # to be divided with 8192 and lead to not repeating decimals.
  ....
  # For example, 
  # if 4.0<= Mag <=4.5, Gisola will use 245.76 sec as inversion time window, 
  # leading to a time kvantum of 246.76/8192=0.03 sec. ....
  ....

@nikosT
Copy link
Owner

nikosT commented Aug 27, 2024

Hi @fanisvl, thanks for this work! The PR will be tested before merging. Could you please also add the respective values in configuration here in a new commit at the same PR?

@fanisvl
Copy link
Author

fanisvl commented Aug 27, 2024

Hi @fanisvl, thanks for this work! The PR will be tested before merging. Could you please also add the respective values in configuration here in a new commit at the same PR?

change Window config & comments for 1024 points

Let me know if I'm missing anything.

@nikosT nikosT marked this pull request as draft September 16, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants