Add missing void return types (#997)

nikic · May 31, 2024 · d57da64 · d57da64
1 parent d327cf2
commit d57da64
Show file tree

Hide file tree

Showing 56 changed files with 283 additions and 283 deletions.
diff --git a/test/PhpParser/Builder/ClassConstTest.php b/test/PhpParser/Builder/ClassConstTest.php
@@ -20,7 +20,7 @@ public function createClassConstBuilder($name, $value) {
         return new ClassConst($name, $value);
     }
 
-    public function testModifiers() {
+    public function testModifiers(): void {
         $node = $this->createClassConstBuilder("TEST", 1)
             ->makePrivate()
             ->getNode()
@@ -82,7 +82,7 @@ public function testModifiers() {
         );
     }
 
-    public function testDocComment() {
+    public function testDocComment(): void {
         $node = $this->createClassConstBuilder('TEST', 1)
             ->setDocComment('/** Test */')
             ->makePublic()
@@ -102,7 +102,7 @@ public function testDocComment() {
         );
     }
 
-    public function testAddConst() {
+    public function testAddConst(): void {
         $node = $this->createClassConstBuilder('FIRST_TEST', 1)
             ->addConst("SECOND_TEST", 2)
             ->getNode();
@@ -118,7 +118,7 @@ public function testAddConst() {
         );
     }
 
-    public function testAddAttribute() {
+    public function testAddAttribute(): void {
         $attribute = new Attribute(
             new Name('Attr'),
             [new Arg(new Int_(1), false, false, [], new Identifier('name'))]
@@ -142,7 +142,7 @@ public function testAddAttribute() {
         );
     }
 
-    public function testType() {
+    public function testType(): void {
         $node = $this->createClassConstBuilder('TYPE', 1)
             ->setType('int')
             ->getNode();
@@ -157,7 +157,7 @@ public function testType() {
     /**
      * @dataProvider provideTestDefaultValues
      */
-    public function testValues($value, $expectedValueNode) {
+    public function testValues($value, $expectedValueNode): void {
         $node = $this->createClassConstBuilder('TEST', $value)
             ->getNode()
         ;

diff --git a/test/PhpParser/Builder/ClassTest.php b/test/PhpParser/Builder/ClassTest.php
@@ -18,7 +18,7 @@ protected function createClassBuilder($class) {
         return new Class_($class);
     }
 
-    public function testExtendsImplements() {
+    public function testExtendsImplements(): void {
         $node = $this->createClassBuilder('SomeLogger')
             ->extend('BaseLogger')
             ->implement('Namespaced\Logger', new Name('SomeInterface'))
@@ -40,7 +40,7 @@ public function testExtendsImplements() {
         );
     }
 
-    public function testAbstract() {
+    public function testAbstract(): void {
         $node = $this->createClassBuilder('Test')
             ->makeAbstract()
             ->getNode()
@@ -54,7 +54,7 @@ public function testAbstract() {
         );
     }
 
-    public function testFinal() {
+    public function testFinal(): void {
         $node = $this->createClassBuilder('Test')
             ->makeFinal()
             ->getNode()
@@ -68,7 +68,7 @@ public function testFinal() {
         );
     }
 
-    public function testReadonly() {
+    public function testReadonly(): void {
         $node = $this->createClassBuilder('Test')
             ->makeReadonly()
             ->getNode()
@@ -82,7 +82,7 @@ public function testReadonly() {
         );
     }
 
-    public function testStatementOrder() {
+    public function testStatementOrder(): void {
         $method = new Stmt\ClassMethod('testMethod');
         $property = new Stmt\Property(
             Modifiers::PUBLIC,
@@ -108,7 +108,7 @@ public function testStatementOrder() {
         );
     }
 
-    public function testDocComment() {
+    public function testDocComment(): void {
         $docComment = <<<'DOC'
 /**
  * Test
@@ -141,7 +141,7 @@ public function testDocComment() {
         );
     }
 
-    public function testAddAttribute() {
+    public function testAddAttribute(): void {
         $attribute = new Attribute(
             new Name('Attr'),
             [new Arg(new Int_(1), false, false, [], new Identifier('name'))]
@@ -162,29 +162,29 @@ public function testAddAttribute() {
         );
     }
 
-    public function testInvalidStmtError() {
+    public function testInvalidStmtError(): void {
         $this->expectException(\LogicException::class);
         $this->expectExceptionMessage('Unexpected node of type "Stmt_Echo"');
         $this->createClassBuilder('Test')
             ->addStmt(new Stmt\Echo_([]))
         ;
     }
 
-    public function testInvalidDocComment() {
+    public function testInvalidDocComment(): void {
         $this->expectException(\LogicException::class);
         $this->expectExceptionMessage('Doc comment must be a string or an instance of PhpParser\Comment\Doc');
         $this->createClassBuilder('Test')
             ->setDocComment(new Comment('Test'));
     }
 
-    public function testEmptyName() {
+    public function testEmptyName(): void {
         $this->expectException(\LogicException::class);
         $this->expectExceptionMessage('Name cannot be empty');
         $this->createClassBuilder('Test')
             ->extend('');
     }
 
-    public function testInvalidName() {
+    public function testInvalidName(): void {
         $this->expectException(\LogicException::class);
         $this->expectExceptionMessage('Name must be a string or an instance of Node\Name');
         $this->createClassBuilder('Test')

diff --git a/test/PhpParser/Builder/EnumCaseTest.php b/test/PhpParser/Builder/EnumCaseTest.php
@@ -17,7 +17,7 @@ public function createEnumCaseBuilder($name) {
         return new EnumCase($name);
     }
 
-    public function testDocComment() {
+    public function testDocComment(): void {
         $node = $this->createEnumCaseBuilder('TEST')
             ->setDocComment('/** Test */')
             ->getNode();
@@ -35,7 +35,7 @@ public function testDocComment() {
         );
     }
 
-    public function testAddAttribute() {
+    public function testAddAttribute(): void {
         $attribute = new Attribute(
             new Name('Attr'),
             [new Arg(new Int_(1), false, false, [], new Identifier('name'))]
@@ -59,7 +59,7 @@ public function testAddAttribute() {
     /**
      * @dataProvider provideTestDefaultValues
      */
-    public function testValues($value, $expectedValueNode) {
+    public function testValues($value, $expectedValueNode): void {
         $node = $this->createEnumCaseBuilder('TEST')
             ->setValue($value)
             ->getNode()

diff --git a/test/PhpParser/Builder/EnumTest.php b/test/PhpParser/Builder/EnumTest.php
@@ -17,7 +17,7 @@ protected function createEnumBuilder($class) {
         return new Enum_($class);
     }
 
-    public function testImplements() {
+    public function testImplements(): void {
         $node = $this->createEnumBuilder('SomeEnum')
             ->implement('Namespaced\SomeInterface', new Name('OtherInterface'))
             ->getNode()
@@ -34,7 +34,7 @@ public function testImplements() {
         );
     }
 
-    public function testSetScalarType() {
+    public function testSetScalarType(): void {
         $node = $this->createEnumBuilder('Test')
             ->setScalarType('int')
             ->getNode()
@@ -48,7 +48,7 @@ public function testSetScalarType() {
         );
     }
 
-    public function testStatementOrder() {
+    public function testStatementOrder(): void {
         $method = new Stmt\ClassMethod('testMethod');
         $enumCase = new Stmt\EnumCase(
             'TEST_ENUM_CASE'
@@ -73,7 +73,7 @@ public function testStatementOrder() {
         );
     }
 
-    public function testDocComment() {
+    public function testDocComment(): void {
         $docComment = <<<'DOC'
 /**
  * Test
@@ -106,7 +106,7 @@ public function testDocComment() {
         );
     }
 
-    public function testAddAttribute() {
+    public function testAddAttribute(): void {
         $attribute = new Attribute(
             new Name('Attr'),
             [new Arg(new Int_(1), false, false, [], new Identifier('name'))]
@@ -127,29 +127,29 @@ public function testAddAttribute() {
         );
     }
 
-    public function testInvalidStmtError() {
+    public function testInvalidStmtError(): void {
         $this->expectException(\LogicException::class);
         $this->expectExceptionMessage('Unexpected node of type "PropertyItem"');
         $this->createEnumBuilder('Test')
             ->addStmt(new Node\PropertyItem('property'))
         ;
     }
 
-    public function testInvalidDocComment() {
+    public function testInvalidDocComment(): void {
         $this->expectException(\LogicException::class);
         $this->expectExceptionMessage('Doc comment must be a string or an instance of PhpParser\Comment\Doc');
         $this->createEnumBuilder('Test')
             ->setDocComment(new Comment('Test'));
     }
 
-    public function testEmptyName() {
+    public function testEmptyName(): void {
         $this->expectException(\LogicException::class);
         $this->expectExceptionMessage('Name cannot be empty');
         $this->createEnumBuilder('Test')
             ->implement('');
     }
 
-    public function testInvalidName() {
+    public function testInvalidName(): void {
         $this->expectException(\LogicException::class);
         $this->expectExceptionMessage('Name must be a string or an instance of Node\Name');
         $this->createEnumBuilder('Test')

diff --git a/test/PhpParser/Builder/FunctionTest.php b/test/PhpParser/Builder/FunctionTest.php
@@ -20,7 +20,7 @@ public function createFunctionBuilder($name) {
         return new Function_($name);
     }
 
-    public function testReturnByRef() {
+    public function testReturnByRef(): void {
         $node = $this->createFunctionBuilder('test')
             ->makeReturnByRef()
             ->getNode()
@@ -34,7 +34,7 @@ public function testReturnByRef() {
         );
     }
 
-    public function testParams() {
+    public function testParams(): void {
         $param1 = new Node\Param(new Variable('test1'));
         $param2 = new Node\Param(new Variable('test2'));
         $param3 = new Node\Param(new Variable('test3'));
@@ -53,7 +53,7 @@ public function testParams() {
         );
     }
 
-    public function testStmts() {
+    public function testStmts(): void {
         $stmt1 = new Print_(new String_('test1'));
         $stmt2 = new Print_(new String_('test2'));
         $stmt3 = new Print_(new String_('test3'));
@@ -76,7 +76,7 @@ public function testStmts() {
         );
     }
 
-    public function testDocComment() {
+    public function testDocComment(): void {
         $node = $this->createFunctionBuilder('test')
             ->setDocComment('/** Test */')
             ->getNode();
@@ -86,7 +86,7 @@ public function testDocComment() {
         ]), $node);
     }
 
-    public function testAddAttribute() {
+    public function testAddAttribute(): void {
         $attribute = new Attribute(
             new Name('Attr'),
             [new Arg(new Int_(1), false, false, [], new Identifier('name'))]
@@ -102,7 +102,7 @@ public function testAddAttribute() {
         ], []), $node);
     }
 
-    public function testReturnType() {
+    public function testReturnType(): void {
         $node = $this->createFunctionBuilder('test')
             ->setReturnType('void')
             ->getNode();
@@ -112,21 +112,21 @@ public function testReturnType() {
         ], []), $node);
     }
 
-    public function testInvalidNullableVoidType() {
+    public function testInvalidNullableVoidType(): void {
         $this->expectException(\LogicException::class);
         $this->expectExceptionMessage('void type cannot be nullable');
         $this->createFunctionBuilder('test')->setReturnType('?void');
     }
 
-    public function testInvalidParamError() {
+    public function testInvalidParamError(): void {
         $this->expectException(\LogicException::class);
         $this->expectExceptionMessage('Expected parameter node, got "Name"');
         $this->createFunctionBuilder('test')
             ->addParam(new Node\Name('foo'))
         ;
     }
 
-    public function testAddNonStmt() {
+    public function testAddNonStmt(): void {
         $this->expectException(\LogicException::class);
         $this->expectExceptionMessage('Expected statement or expression node');
         $this->createFunctionBuilder('test')