Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upload image #15

Merged
merged 1 commit into from
Aug 22, 2017
Merged

upload image #15

merged 1 commit into from
Aug 22, 2017

Conversation

nicholasgubbins
Copy link
Owner

@nicholasgubbins nicholasgubbins commented Aug 22, 2017 •
edited
Loading

What did you implement:

Added a new POST endpoint for generating a signed S3 url which can be used to upload to S3 bucket

How did you implement it:

created a new function, used AWS "getSignedUrl" function

How can we verify it:

Todos:

  • Write documentation
  • Fix linting errors
  • Change the permissions for the function on serverless.yml to give this function the ability to do putobject requests

Is this ready for review?: YES
Is it a breaking change?: YES

@marcusmolchany marcusmolchany self-requested a review August 22, 2017 15:05
@marcusmolchany
Copy link
Collaborator

Part of #2

@marcusmolchany marcusmolchany merged commit e8d6829 into master Aug 22, 2017
@marcusmolchany marcusmolchany deleted the uploader branch August 22, 2017 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcusmolchany marcusmolchany marcusmolchany approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicholasgubbins @marcusmolchany